RFR: 8324213: C1: There is no need for Canonicalizer to handle IfOp [v2]

Denghui Dong ddong at openjdk.org
Mon Jan 29 09:44:47 UTC 2024


On Mon, 29 Jan 2024 09:13:12 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> src/hotspot/share/c1/c1_Canonicalizer.cpp line 472:
> 
>> 470: 
>> 471: void Canonicalizer::do_IfOp(IfOp* x) {
>> 472:   ShouldNotReachHere();
> 
> Looks good, but maybe add a comment here why we cannot visit `IfOp` here (i.e. that `IfOp` is not created by the `GraphBuilder` but only later when eliminating conditional expressions with `CE_Eliminator`).

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17499#discussion_r1469318739


More information about the hotspot-compiler-dev mailing list