RFR: JDK-8322648: Improve class initialization barrier in TemplateTable::_new for PPC [v3]

Varada M varadam at openjdk.org
Mon Jan 29 15:39:25 UTC 2024


On Mon, 29 Jan 2024 15:07:23 GMT, Varada M <varadam at openjdk.org> wrote:

>> ppc port implementation of https://github.com/openjdk/jdk/pull/17006
>> 
>> Fastdebug and Release : build and tier1 testing successful.
>> 
>> JBS Issue : [JDK-8322648](https://bugs.openjdk.org/browse/JDK-8322648)
>
> Varada M has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8322648: Improve class initialization barrier in TemplateTable::_new for PPC

> Seems like you have missed my previous comment: [#17518 (review)](https://github.com/openjdk/jdk/pull/17518#pullrequestreview-1847895107) I don't think it's correct without that. And please remove the comment "// get instance_size.". It doesn't tell anything which is not obvious. We should definitely measure performance with -Xint. Maybe even "time java -Xint -version" shows a difference between correct and incorrect code.

I see a minor difference in real time and CPU time

Without the code change : 

real    0m0.714s
user    0m0.381s
sys     0m0.026s


With the code change : 

real    0m0.711s
user    0m0.380s
sys     0m0.026s`

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17518#issuecomment-1914951250


More information about the hotspot-compiler-dev mailing list