RFR: 8324667: fold Parse::seems_stable_comparison() [v2]

Xin Liu xliu at openjdk.org
Mon Jan 29 19:57:42 UTC 2024


On Thu, 25 Jan 2024 19:05:50 GMT, Joshua Cao <duke at openjdk.org> wrote:

>> The function has a long comment block that seems irrelevant since https://github.com/openjdk/jdk/commit/8bd4b5624c6ece31d965259aadc290a24d44423a. We can just fold away this method. It only has one caller.
>> 
>> 
>> passes GHA
>
> Joshua Cao has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update copyright for parse.hpp
>  - Remove seems_stable_comparison() from header and remove copyright

LGTM. I am not a reviewer.

-------------

Marked as reviewed by xliu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17573#pullrequestreview-1849637781


More information about the hotspot-compiler-dev mailing list