RFR: 8320237 C2: late inlining of method handle invoke causes duplicate lines in PrintInlining output [v3]

Tobias Hartmann thartmann at openjdk.org
Tue Jan 30 10:51:45 UTC 2024


On Mon, 22 Jan 2024 16:28:02 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:

>> This PR resolves [JDK-8320237](https://bugs.openjdk.org/browse/JDK-8320237)
>> 
>> The original behavior produces both a failure and success message upon late inlining which is confusing. The patch removes the failure message if inlining was successful. Huge thanks to @rwestrel for reporting and working out a solution.
>> 
>> Unit test `test/hotspot/jtreg/compiler/inlining/TestDuplicatedLateInliningOutput.java` is added and passing.
>
> Kangcheng Xu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - add -XX:-BackgroundCompilation flag
>  - Merge branch 'master' into JDK-8320237
>  - fix VM crashes
>  - update test summary, requirements, and VM flags
>  - Merge branch 'master' into JDK-8320237
>  - make regex whitespace consistent
>    
>    and to trigger GHA
>  - 8320237: C2: late inlining of method handle invoke causes duplicate lines in PrintInlining output

All tests passed.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17147#pullrequestreview-1850867320


More information about the hotspot-compiler-dev mailing list