RFR: JDK-8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java
Tobias Hartmann
thartmann at openjdk.org
Wed Jan 31 12:58:02 UTC 2024
On Wed, 31 Jan 2024 11:37:03 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Hi,
>> Can you help to review this simple patch to fix test TestRoundVectFloat.java?
>> Thanks!
>>
>> FYI: This test is not actually tested, need to fix the test applying filter and IR matching rule.
>
> test/hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java line 52:
>
>> 50:
>> 51: @Test
>> 52: @IR(applyIf = {"UseAVX", " > 1"}, counts = {IRNode.ROUND_VF , " > 0 "})
>
> Isn't that node only available if `UseAVX >= 2`?
> https://github.com/openjdk/jdk/blob/f0bae7939a61a79f3e07de97451c433e91742069/src/hotspot/cpu/x86/x86.ad#L1501-L1504
Sorry, misread the code. Looks good.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17649#discussion_r1472782987
More information about the hotspot-compiler-dev
mailing list