RFR: 8324679: Replace NULL with nullptr in HotSpot .ad files
Coleen Phillimore
coleenp at openjdk.org
Wed Jan 31 20:16:02 UTC 2024
On Wed, 31 Jan 2024 18:43:20 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> This is a straightforward mechanical (sed) replacement of NULL with nullptr. One string was adjusted to not say nullptr ptr. nullptr makes sense in the comments so I didn't change them.
>>
>> Tested with tier1 Oracle platforms and build test with linux-x64-zero,linux-x64-zero-debug,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug,linux-riscv64-debug
>
> src/hotspot/cpu/aarch64/aarch64.ad line 4666:
>
>> 4664: %}
>> 4665:
>> 4666: // nullptr Pointer Immediate
>
> Should we keep NULL here?
How about Null Pointer for these?
> src/hotspot/cpu/x86/x86_64.ad line 5172:
>
>> 5170: %}
>> 5171:
>> 5172: // Store nullptr Pointer, mark word, or other simple pointer constant.
>
> Keep `NULL`
I made this one Null too since we don't want to find NULL in the code because it'll look like this change backtracked.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17658#discussion_r1473409334
PR Review Comment: https://git.openjdk.org/jdk/pull/17658#discussion_r1473410427
More information about the hotspot-compiler-dev
mailing list