RFR: 8324679: Replace NULL with nullptr in HotSpot .ad files [v2]

Coleen Phillimore coleenp at openjdk.org
Wed Jan 31 23:09:23 UTC 2024


On Wed, 31 Jan 2024 20:22:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is a straightforward mechanical (sed) replacement of NULL with nullptr.  One string was adjusted to not say nullptr ptr.  nullptr makes sense in the comments so I didn't change them.
>> 
>> Tested with tier1 Oracle platforms and build test with linux-x64-zero,linux-x64-zero-debug,linux-s390x-open,linux-arm32-debug,linux-ppc64le-debug,linux-riscv64-debug
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix comments to Null Pointer and strings to null pointer.

src/hotspot/cpu/arm/arm.ad line 807:

> 805: #ifndef PRODUCT
> 806: void MachSpillCopyNode::format( PhaseRegAlloc *ra_, outputStream *st ) const {
> 807:   implementation( nullptr, ra_, false, st );

Suggestion:

  implementation(nullptr, ra_, false, st );

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17658#discussion_r1473590768


More information about the hotspot-compiler-dev mailing list