RFR: 8324679: Replace NULL with nullptr in HotSpot .ad files [v2]

Coleen Phillimore coleenp at openjdk.org
Wed Jan 31 23:32:02 UTC 2024


On Wed, 31 Jan 2024 23:05:35 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/cpu/arm/arm.ad line 807:
>> 
>>> 805: #ifndef PRODUCT
>>> 806: void MachSpillCopyNode::format( PhaseRegAlloc *ra_, outputStream *st ) const {
>>> 807:   implementation( nullptr, ra_, false, st );
>> 
>> Suggestion:
>> 
>>   implementation(nullptr, ra_, false, st );
>
> It's the square with the +- in it to the right of "Preview".

The only trick with this button is that if you commit the suggestion, you have to pull it back to your local repo in case you want to make more changes there.

Also if you use the suggestion button, you become co-author, which is a bit odd.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17658#discussion_r1473611222


More information about the hotspot-compiler-dev mailing list