RFR: 8335390: C2 MergeStores: wrong result with Unsafe

Tobias Hartmann thartmann at openjdk.org
Mon Jul 1 12:51:54 UTC 2024


On Mon, 1 Jul 2024 08:38:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> In JDK23, I introduced `MergeStores` [JDK-8318446](https://bugs.openjdk.org/browse/JDK-8318446) https://github.com/openjdk/jdk/pull/16245.
> 
> I now realized that the pointer-parsing has some issues with `Unsafe` stores. Thus, I disable the optimization for those for now.
> 
> **Future Work**
> In [JDK-8335392](https://bugs.openjdk.org/browse/JDK-8335392), I plan to redesign the pointer-parsing, and enable more features, including `Unsafe` stores.

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19964#pullrequestreview-2150795418


More information about the hotspot-compiler-dev mailing list