Integrated: 8334816: compiler/c2/irTests/TestIfMinMax.java fails after 8334629
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Tue Jul 2 14:39:23 UTC 2024
On Sun, 30 Jun 2024 02:39:57 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:
> This PR fixes an issue discovered during the review of #19650, where TestIfMinMax produced some IR failures. This issue is similar to the one in #18734, where a rare case could cause the same failure when the branch taken percent was too low. The fix there was to add 50 positive and 50 negative elements to the array, which guarantees that the IfNode will have a branch probability of at least 0.098. However, since the threshold has been increased from 0.01 to 0.18, the amount of sequential elements needs to be increased. I've increased it to 125 so the probability is guaranteed to be at least 0.24, which is larger than the threshold needed to convert to CMove.
>
> Thoughts and reviews would be appreciated!
This pull request has now been integrated.
Changeset: 685e5878
Author: Jasmine Karthikeyan <jkarthikeyan at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/685e5878b823fa5e3ae88ffd76de6507d6057af2
Stats: 13 lines in 2 files changed: 0 ins; 1 del; 12 mod
8334816: compiler/c2/irTests/TestIfMinMax.java fails after 8334629
Reviewed-by: thartmann, chagedorn
-------------
PR: https://git.openjdk.org/jdk/pull/19959
More information about the hotspot-compiler-dev
mailing list