RFR: 8321509: False positive in get_trampoline fast path causes crash [v3]

[Dean Long]

On Tue, 25 Jun 2024 23:49:27 GMT, Dean Long <dlong at openjdk.org> wrote:

>> 8321509: False positive in get_trampoline fast path causes crash
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup

To fix Leyden premain, I'd suggest to change the "nmethod expected" assert in NativeCall::destination() into conditional code that returns the "raw" destination if it is not an nmethod, and optionally restore the following performance optimization (with a comment as suggested by Vladimir):

// Performance optimization: no need to call find_blob() if it is a self-call
if (destination == addr) {
  return destination;
}

But I don't have a strong opinion on whether it should be fixed here or only in Leyden.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19796#issuecomment-2205014329