RFR: 8335536: Fix assertion failure in IdealGraphPrinter when append is true [v2]

Qizheng Xing qxing at openjdk.org
Wed Jul 3 06:34:31 UTC 2024


> When `IdealGraphPrinter` is created with `append` set to true, it does not write the head element to the file in its constructor. But in the destructor, it always writes the tail element to the file no matter `append` is true or not, which causes an assertion failure in `xmlStream::pop_tag`.
> 
> This issue can be reproduced by calling `igv_append` directly, or by calling `Compile::igv_print_method_to_file` with `append` set to true.
> 
> This patch fixes the issue.

Qizheng Xing has updated the pull request incrementally with one additional commit since the last revision:

  Add comments for `IdealGraphPrinter::update_compiled_method`.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19986/files
  - new: https://git.openjdk.org/jdk/pull/19986/files/42de6316..269bb1c2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19986&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19986&range=00-01

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/19986.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19986/head:pull/19986

PR: https://git.openjdk.org/jdk/pull/19986


More information about the hotspot-compiler-dev mailing list