Integrated: 8335536: Fix assertion failure in IdealGraphPrinter when append is true

Qizheng Xing qxing at openjdk.org
Wed Jul 3 12:14:25 UTC 2024


On Tue, 2 Jul 2024 09:31:32 GMT, Qizheng Xing <qxing at openjdk.org> wrote:

> When `IdealGraphPrinter` is created with `append` set to true, it does not write the head element to the file in its constructor. But in the destructor, it always writes the tail element to the file no matter `append` is true or not, which causes an assertion failure in `xmlStream::pop_tag`.
> 
> This issue can be reproduced by calling `igv_append` directly, or by calling `Compile::igv_print_method_to_file` with `append` set to true.
> 
> This patch fixes the issue.

This pull request has now been integrated.

Changeset: 6db4c6a7
Author:    Qizheng Xing <qxing at openjdk.org>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6db4c6a772df856fc3099c32a5b2c102a30d360c
Stats:     22 lines in 2 files changed: 11 ins; 0 del; 11 mod

8335536: Fix assertion failure in IdealGraphPrinter when append is true

Reviewed-by: thartmann, chagedorn, tholenstein

-------------

PR: https://git.openjdk.org/jdk/pull/19986


More information about the hotspot-compiler-dev mailing list