RFR: 8317721: RISC-V: Implement CRC32 intrinsic [v13]

ArsenyBochkarev duke at openjdk.org
Wed Jul 3 12:23:30 UTC 2024


On Wed, 3 Jul 2024 11:55:04 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Whoops, looks like it is a leftover from [this](https://github.com/openjdk/jdk/pull/17046/commits/654b25b7e5a0fa17eedbdaf3a3de66ba53c28420) commit, and I missed it. I don't think it costs performance much, and it is functionally correct, but it truly is an unnecessary alias (the `compiler/intrinsics/zip/TestCRC32.java` is ok without it)
>
> Better to remove it as it might confuse people making the code hard to understand. And it deserve a code comment for this if-else as it doesn't look obvious about the difference between using `srli` and `srliw` here.

Sure! See the https://bugs.openjdk.org/browse/JDK-8335615

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17046#discussion_r1664101347


More information about the hotspot-compiler-dev mailing list