RFR: 8332163: C2 SuperWord: refactor PacksetGraph and SuperWord::output into VTransformGraph [v10]
Emanuel Peter
epeter at openjdk.org
Wed Jul 3 14:10:29 UTC 2024
On Tue, 2 Jul 2024 13:11:00 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> src/hotspot/share/opto/superword.cpp line 1899:
>>
>>> 1897: C->print_method(PHASE_AUTO_VECTORIZATION2_AFTER_REORDER, 4, cl());
>>> 1898:
>>> 1899: adjust_pre_loop_limit_to_align_main_loop_vectors();
>>
>> Same thought here: Could this be a separate class? It looks like adjusting the pre loop is not really something the graph should know about. We are rather using information about the graph (i.e. the graph could be passed to the schedule class).
>
> We could do this in a separate RFE, yes. I only moved it over from SuperWord.
Maybe this is now not necessary any more: this is part of the "transform", and not of the "graph" any more. The graph and the pre-loop-adjustments are both parts of the transform.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19719#discussion_r1664237719
More information about the hotspot-compiler-dev
mailing list