RFR: 8332163: C2 SuperWord: refactor PacksetGraph and SuperWord::output into VTransformGraph [v11]

Christian Hagedorn chagedorn at openjdk.org
Thu Jul 4 09:35:35 UTC 2024


On Tue, 2 Jul 2024 13:23:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> I guess the extra `vtnodes` during edge creation is only for inputs that come from outside the loop... hmm.
>> 
>> What about:
>> 
>> build_edges_for_vector_vtnodes -> build_inputs_for_vector_vtnodes
>> build_edges_for_scalar_vtnodes -> build_inputs_for_scalar_vtnodes
>> 
>> And of course if the inputs are already built, we can just connect those.
>
> Renamed it and added some comments, lmk if you have an even better idea.

That's better, I like it! Before that it first suggested (without looking at the code in more detail) that we have a fixed set of vtnodes and then just build some edges (now it's even more clear that it's about inputs and not outputs).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19719#discussion_r1665429178


More information about the hotspot-compiler-dev mailing list