RFR: 8332163: C2 SuperWord: refactor PacksetGraph and SuperWord::output into VTransformGraph [v11]
Emanuel Peter
epeter at openjdk.org
Thu Jul 4 10:07:26 UTC 2024
On Thu, 4 Jul 2024 09:15:18 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> rm newline
>
> src/hotspot/share/opto/superword.cpp line 3036:
>
>> 3034: bool SuperWord::same_generation(Node* a, Node* b) const {
>> 3035: return a != nullptr && b != nullptr && _clone_map.same_gen(a->_idx, b->_idx);
>> 3036: }
>
> Just noticed this by coincidence: This method is dead and can be removed. Can probably also be done in the scope of this PR instead of doing an extra RFE just for that.
I'll need to look into the CloneMap separately at some point, so I'll do it then. I'm aware of this one ;)
[JDK-8303113](https://bugs.openjdk.org/browse/JDK-8303113): [SuperWord] investigate if enabling _do_vector_loop by default creates speedup
I hope that one day I can remove the whole `CloneMap` and `_do_vector_loop`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19719#discussion_r1665475055
More information about the hotspot-compiler-dev
mailing list