RFR: 8335257: Refactor code to create Initialized Assertion Predicates into separate class [v2]

Christian Hagedorn chagedorn at openjdk.org
Fri Jul 5 08:56:49 UTC 2024


On Wed, 3 Jul 2024 15:17:20 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/predicates.cpp line 412:
>> 
>>> 410: IfTrueNode* InitializedAssertionPredicate::create(Node* control) {
>>> 411:   IdealLoopTree* loop = _phase->get_loop(control);
>>> 412:   OpaqueInitializedAssertionPredicateNode* new_opaque_bool = create_new_bool(control);
>> 
>> This is confusing: I ask for a `bool` but get an `opaque`...
>
> Better might be: `create_initialized_assertion_predicate_expression`

See comment below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19940#discussion_r1666497672


More information about the hotspot-compiler-dev mailing list