RFR: 8335257: Refactor code to create Initialized Assertion Predicates into separate class [v2]

[Emanuel Peter]

On Fri, 5 Jul 2024 09:00:49 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - review Emanuel
>>  - Merge branch 'refs/heads/master' into JDK-8335257
>>  - 8335257: Refactor code to create Initialized Assertion Predicates into separate class
>
> src/hotspot/share/opto/predicates.cpp line 427:
> 
>> 425:       assertion_expression.clone_and_replace_init_and_stride(_new_init, _new_stride, control, _phase);
>> 426:   OpaqueInitializedAssertionPredicateNode* assertion_predicate_expression
>> 427:       = new OpaqueInitializedAssertionPredicateNode(tmp_opaque->in(1)->as_Bool(), _phase->C);
> 
> Decide if you want the `=` on the first or last line and do it consistently ;)

Long names are so nice, but the code does get a big difficult to format 😅

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19940#discussion_r1666545084