RFR: 8335257: Refactor code to create Initialized Assertion Predicates into separate class [v3]

Christian Hagedorn chagedorn at openjdk.org
Fri Jul 5 09:43:47 UTC 2024


> This is the next patch for Assertion Predicates. It refactors the code to create an Initialized Assertion Predicate. Changes include:
> 
> - `clone_assertion_predicate_and_initialize()` currently does two things: Cloning a Template Assertion Predicate and creating an Initailized Assertion Predicate. I've split this method into two methods `clone_template_assertion_predicate()` and `create_initialized_assertion_predicate()`:
>   - `clone_template_assertion_predicate()`: Now only clones the template. I have not cleaned the code up further because I will soon replace the `If` node with a dedicated `TemplateAssertionPredicateNode`. 
>   - `create_initialized_assertion_predicate()`: I refactored the code for Initialized Assertion Predicate into a separate class `InitializedAssertionPredicate` which creates the complete Initialized Assertion Predicate `If` with a `HaltNode`. I could get rid of some of the arguments because they can be fetched inside the new class methods.
>   - Moved `assertion_predicate_has_loop_opaque_node()` asserts to both methods.
> - Renamed `AssertionPredicateType::Init_value` -> `AssertionPredicateType::InitValue` (same for last value).
> 
> Thanks,
> Christian

Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:

  update transformation sketch and rename "Template Assertion Predicate Expression" to "Template Assertion Expression"

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19940/files
  - new: https://git.openjdk.org/jdk/pull/19940/files/b43604ab..6f660554

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19940&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19940&range=01-02

  Stats: 77 lines in 6 files changed: 0 ins; 1 del; 76 mod
  Patch: https://git.openjdk.org/jdk/pull/19940.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19940/head:pull/19940

PR: https://git.openjdk.org/jdk/pull/19940


More information about the hotspot-compiler-dev mailing list