RFR: 8333890: Fatal error in auto-vectorizer with float16 kernel. [v2]
Emanuel Peter
epeter at openjdk.org
Mon Jul 8 10:31:37 UTC 2024
On Mon, 8 Jul 2024 06:41:22 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Good.
>
> Thanks @vnkozlov for review and approval.
@jatin-bhateja our rule is generally that a PR should have 2 reviews. Unless both the author and reviewer say that it is trivial.
I would have had these comments if I had time to review this:
`@requires vm.compiler2.enabled`
This is not required in the test, it would be nice to run tests also if C2 is not available, e.g. with graal or C1.

You should have adjusted the title of the PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20062#issuecomment-2213635730
More information about the hotspot-compiler-dev
mailing list