RFR: 8333890: Fatal error in auto-vectorizer with float16 kernel. [v2]

Emanuel Peter epeter at openjdk.org
Mon Jul 8 10:46:43 UTC 2024


On Mon, 8 Jul 2024 10:42:53 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   IR rule extension for ANY vector size
>
> test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorConvChain.java line 42:
> 
>> 40: 
>> 41:     @Test
>> 42:     @IR(counts = {IRNode.VECTOR_CAST_HF2F, IRNode.VECTOR_SIZE_ANY, ">= 1", IRNode.VECTOR_CAST_F2HF, IRNode.VECTOR_SIZE_ANY, " >= 1"})
> 
> You are missing restrictions to platforms where these vector operations are supported.

If we had run testing on this, we should have easily caught this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20062#discussion_r1668405403


More information about the hotspot-compiler-dev mailing list