RFR: 8327381: Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v10]

Tobias Hartmann thartmann at openjdk.org
Mon Jul 8 14:02:44 UTC 2024


On Tue, 18 Jun 2024 14:24:02 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into boolnode-refactor
>>  - move test location, add negative test case, simplify imports
>>  - Merge branch 'master' into boolnode-refactor
>>  - refactor BoolNode::Value() and extract code to ::Value_cmpu_and_mask
>>  - update comments
>>  - fix indentation again
>>  - apply test only on x64, aarch64 and riscv64
>>  - also renames the class name in @run
>>  - update test @run annotation
>>  - improve formatting, correct annotation and rename test class
>>  - ... and 8 more: https://git.openjdk.org/jdk/compare/527ff5f6...84784c74
>
> PR updated according to requests. It looked like GHA previously had a problem with serviceability tests across the repo. Let's wait until the new round of testing is complete.

@tabjy any update on this? Let us know if you need help with reproducing the issue that Christian reported. Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18198#issuecomment-2214159841


More information about the hotspot-compiler-dev mailing list