RFR: 8321509: False positive in get_trampoline fast path causes crash [v3]

[Andrew Dinn]

On Tue, 25 Jun 2024 23:49:27 GMT, Dean Long <dlong at openjdk.org> wrote:

>> 8321509: False positive in get_trampoline fast path causes crash
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup

>       address NativeCall::destination() const {
>         address addr = instruction_address();
>         address destination = addr + displacement();
>     
>     +   // Performance optimization: no need to call find_blob() if it is a self-call
>     +   if (destination == addr) {
>     +     return destination;
>     +   }
>
> . . .
>
> @adinn, I suggest you to test these changes with leyden changes for stubs.

@vnkozlov I applied @dean-long's patch to my Leyden premain repo that saves and restores generated stubs. Without the above extra patch it crashes. With it everything works fine.

So, @dean-long assuming the above tweak is applied I believe it is good to go.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19796#issuecomment-2214425070