RFR: 8321509: False positive in get_trampoline fast path causes crash [v3]

[Vladimir Kozlov]

On Tue, 25 Jun 2024 23:49:27 GMT, Dean Long <dlong at openjdk.org> wrote:

>> 8321509: False positive in get_trampoline fast path causes crash
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup

It was missing Leyden is 'ON' check:

   static bool codestub_branch_needs_far_jump() {
+    if (SCCache::is_on_for_write()) {
+      return true;
+    }


After fixing it I hit the assert in `nativeInst_aarch64.cpp` as @dean-long predicted:


#  Internal Error (/Users/vkozlov/work/leyden/open/src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp:63), pid=75825, tid=27139
#  assert(cb != nullptr && cb->is_nmethod()) failed: nmethod expected

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19796#issuecomment-2218188509