RFR: 8321509: False positive in get_trampoline fast path causes crash [v3]

[Evgeny Astigeevich]

On Wed, 10 Jul 2024 14:44:57 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> > I don't think `is_always_within_branch_range()` needs any changes. As I wrote its return value is based on static CodeCache information.
> 
> For runtime call inside CodeCache `reachable_from_branch_at()` can give different answer when loading AOT code. There is no guarantee that CodeCache size will be the same.

With my limited knowledge of AOT code, we should always generate trampoline based code for AArch64. `is_always_within_branch_range()` should either not be used for AOT or should always return false. Trampoline calls are optimized to direct calls if possible when code is move into CodeCache.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19796#issuecomment-2220778720