RFR: 8321509: False positive in get_trampoline fast path causes crash [v2]

[Evgeny Astigeevich]

On Tue, 25 Jun 2024 21:43:34 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Previously, get_trampoline() was called on CodeBuffer/CodeBlob during expansion, but now it is only called by set_destination_mt_safe, so it should be OK to assert that it is an nmethod.
>
> Good.

> Is it because trampolines are not used by not nmethods? Should we have an assert here about that?

See docs on different types of calls AArch64 uses: https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp#L1183

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19796#discussion_r1672449684