RFR: 8321509: False positive in get_trampoline fast path causes crash [v3]

[Dean Long]

On Wed, 10 Jul 2024 15:19:49 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>>> So for Leyden it sounds like you need to change is_always_within_branch_range().
>> 
>> Or perhaps just adapt MacroAssembler::far_branches(). It returns false if the code cache max range exceeds branch_range. In Leyden we can make it return false when we are generating AOT code.
>
>> > So for Leyden it sounds like you need to change is_always_within_branch_range().
>> 
>> Or perhaps just adapt MacroAssembler::far_branches(). It returns false if the code cache max range exceeds branch_range. In Leyden we can make it return false when we are generating AOT code.
> 
> We might need to adapt [`target_needs_far_branch`](https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L677) for AOT code generation.

I'll wait until tomorrow to push, in case there are still concerns/questions from @eastig or @adinn .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19796#issuecomment-2221635100