RFR: 8331194: NPE in ArrayCreationTree.java with -XX:-UseCompressedOops [v2]
Cesar Soares Lucas
cslucas at openjdk.org
Thu Jul 11 19:21:01 UTC 2024
On Thu, 11 Jul 2024 15:38:10 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Update src/hotspot/share/opto/output.cpp
>>
>> Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>> - Update src/hotspot/share/opto/machnode.hpp
>>
>> Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>
> You can use `-XX:+IgnoreUnrecognizedVMOptions` flag instead of require "vm.bits".
> Yes, do second run without flags.
>
> I also suggest put test into corresponding directory `compiler/escapeAnalysis`. `compiler/c2` is used for legacy or some C2 general tests.
@vnkozlov @eme64 - I moved all tests related to "RAM" to the suggested folder and modified the test, added in this PR, to remove the flags as you suggested.
Please, let me ask more about configuring the test to run without flags. Without the flags, for instance, the CompileCommands, the IR graph will very likely not be in the shape that trigger the problem. Even with the CompileCommands, if some other flags included in the list of flags to run the test, the IR graph may also not be in the shape that will trigger the problem. Why run the test if it doesn't trigger the problem it was intended for? I'm probably missing something here.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20087#issuecomment-2223707221
More information about the hotspot-compiler-dev
mailing list