RFR: 8331194: NPE in ArrayCreationTree.java with -XX:-UseCompressedOops [v4]

[Emanuel Peter]

On Fri, 12 Jul 2024 06:52:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert moving tests.
>>  - Revert moving tests. Another rename.
>
> test/hotspot/jtreg/compiler/escapeAnalysis/TestReduceAllocationAndNestedScalarized.java line 31:
> 
>> 29:  *          needs to be rematerialized because it's used regardless of the
>> 30:  *          Phi output.
>> 31:  * @requires vm.compiler2.enabled
> 
> Again, I think you do not neet do restrict test execution to C2. The `requires` does not make C2 appear magically, but rather it just means the test is not executed if C2 is not available. So why restrict the test? Maybe some other compiler also has a similar or totally different bug triggered with your test. Would that not be nice?

Now that you have `-XX:+IgnoreUnrecognizedVMOptions`, you do not have to be worried that some other compiler crashes because of some unrecognized flag.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20087#discussion_r1675401069