RFR: 8336256: memcpy short value to int local is incorrect in VtableStubs::unsafe_hash

Thomas Stuefe stuefe at openjdk.org
Fri Jul 12 08:01:51 UTC 2024


On Thu, 11 Jul 2024 14:18:07 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> Make sure the local variable used as target of the `memcpy` in `VtableStubs::unsafe_hash` has the same size as `VtableStub::_index` which is the source of the `memcpy`.
> 
> With this fix we don't see the crashes reported in the JBS-issue.
> 
> JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. Renaissance Suite and SAP specific tests.
> Testing was done with fastdebug and release builds on the main platforms and also on Linux/PPC64le and AIX.

Makes sense.

Was that a big endian problem?

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20137#pullrequestreview-2174118013


More information about the hotspot-compiler-dev mailing list