RFR: 8335860: compiler/vectorization/TestFloat16VectorConvChain.java fails with non-standard AVX/SSE settings

[Sandhya Viswanathan]

On Fri, 12 Jul 2024 18:26:26 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

> Enabling test with explicit feature checks for x86 target.
> Removing from test/hotspot/jtreg/ProblemList.txt
> 
> Best Regards,
> Jatin

src/hotspot/cpu/x86/vm_version_x86.hpp line 838:

> 836: 
> 837:   // For AVX CPUs only since it needs VEX encoding which is missing on SSE targets,
> 838:   // thus f16c support is disabled if UseAVX == 0.

This comment is somewhat or vey confusing. The code for supports_float16() by itself is very clear. I am wondering why do we need this explanation in the comment at all? Let us remove it altogether.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20160#discussion_r1679872428