RFR: 8336346: Fix -Wzero-as-null-pointer-constant warnings in jvmciJavaClasses.cpp [v2]

Julian Waters jwaters at openjdk.org
Wed Jul 17 00:49:54 UTC 2024


On Tue, 16 Jul 2024 17:28:23 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this trivial change to remove -Wzero-as-null-pointer-constant
>> warnings (when enabled), triggered by assignment to or comparison with a
>> jfieldID (a pointer type) with a value of 0.  Changing the value to nullptr
>> removes the warnings.
>> 
>> Because these changes are in macros that are used many times, this change
>> removes about 100 warnings.
>> 
>> Testing: mach5 tier1
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix backslash alignment in jvmciJavaClasses change

Marked as reviewed by jwaters (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20175#pullrequestreview-2181548006


More information about the hotspot-compiler-dev mailing list