RFR: 8336258: Document the behavior of 'exclude' and 'compileonly' with respect to inlining [v2]
Volker Simonis
simonis at openjdk.org
Thu Jul 18 14:43:44 UTC 2024
On Thu, 18 Jul 2024 14:36:33 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:
>> Volker Simonis has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Added comma as suggested by @jaskarth
>> - Updated documentation text according to Tobias' suggestion
>
> src/hotspot/share/compiler/compilerOracle.cpp line 641:
>
>> 639: tty->cr();
>> 640: tty->print_cr("The 'exclude' command excludes methods from top-level compilations as well as");
>> 641: tty->print_cr("from inlining whereas the 'compileonly' command only excludes methods from");
>
> Suggestion:
>
> tty->print_cr("from inlining, whereas the 'compileonly' command only excludes methods from");
Thanks for the suggestion. Updated as proposed by you.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20142#discussion_r1682974743
More information about the hotspot-compiler-dev
mailing list