RFR: 8336258: Document the behavior of 'exclude' and 'compileonly' with respect to inlining [v2]
Volker Simonis
simonis at openjdk.org
Thu Jul 18 14:43:45 UTC 2024
On Thu, 18 Jul 2024 11:37:56 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Volker Simonis has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Added comma as suggested by @jaskarth
>> - Updated documentation text according to Tobias' suggestion
>
> src/hotspot/share/compiler/compilerOracle.cpp line 642:
>
>> 640: tty->print_cr("The 'exclude' command excludes methods from top-level compilations as well as");
>> 641: tty->print_cr("from inlining whereas the 'compileonly' command only excludes methods from");
>> 642: tty->print_cr("top-level compilations (i.e. they still can be inlined into other compilation units).");
>
> Suggestion:
>
> tty->print_cr("top-level compilations (i.e. they can still be inlined into other compilation units).");
Thanks for looking at this PR! I've updated the text according to your suggestion.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20142#discussion_r1682970604
More information about the hotspot-compiler-dev
mailing list