RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

Tobias Hartmann thartmann at openjdk.org
Fri Jul 19 10:44:32 UTC 2024


On Fri, 19 Jul 2024 09:50:43 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 40:
>> 
>>> 38: /**
>>> 39:  * @test
>>> 40:  * @bug 8240989 8336753
>> 
>> I don't think that change makes sense because the test is not a regression test for JDK-8336753.
>
> Can/should I include the bug number in some other way (perhaps directly in the comment)? I'm thinking if someone reads the comment in the future and would like more details.

I don't think that's necessary, one can always find the changeset that added a specific line/comment via the git history.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20237#discussion_r1684193424


More information about the hotspot-compiler-dev mailing list