RFR: 8336663: [JVMCI] VM Crash on ZGC due to incompatible handle returned by HotSpotJVMCIRuntime#getJObjectValue [v2]

[Tomáš Zezula]

On Wed, 17 Jul 2024 17:27:48 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Tomáš Zezula has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improved getJObjectValue ducumentation.
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java line 928:
> 
>> 926: 
>> 927:     /**
>> 928:      * Gets the {@code jobject} value wrapped by {@code peerObject}. The returned "naked" value is
> 
> Remove `"naked"` since a JNI value is a proper handle and not really naked.

Fixed by d10f81847f27dfe413ace2521aec2f76647f4071

> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java line 929:
> 
>> 927:     /**
>> 928:      * Gets the {@code jobject} value wrapped by {@code peerObject}. The returned "naked" value is
>> 929:      * a JNI local reference, which is valid for the duration of a JVMCI shared library call. This
> 
> "which is valid for the duration of a JVMCI shared library call"
> 
> This is a bit ambiguous for a reader not fully aware of the dual JNI environments in play. One may think the call to this method is a "JVMCI shared library call". Can you express this some other way that doesn't make it sound like the return value is invalid?

Fixed by d10f81847f27dfe413ace2521aec2f76647f4071

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20219#discussion_r1684410721
PR Review Comment: https://git.openjdk.org/jdk/pull/20219#discussion_r1684411274