RFR: 8336692: Redo fix for JDK-8284620
Dean Long
dlong at openjdk.org
Sat Jul 20 02:25:38 UTC 2024
On Sat, 20 Jul 2024 02:20:23 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> src/hotspot/share/asm/codeBuffer.cpp line 139:
>>
>>> 137: cb->free_blob();
>>> 138: // free any overflow storage
>>> 139: delete cb->_overflow_arena;
>>
>> With this change, only this->_overflow_arena will be non-null after exapdn(). In expand() we won't copy this value to the buffer in _before_expand, so we can move this delete outside the loop like before.
>
> I moved it outside. I only added `!= nullptr` check which may look like we still inside loop.
Sorry, I read it wrong.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20236#discussion_r1685215036
More information about the hotspot-compiler-dev
mailing list