RFR: 8336489: Track scoped accesses in JVMCI compiled code [v3]
Doug Simon
dnsimon at openjdk.org
Wed Jul 24 09:48:34 UTC 2024
On Mon, 22 Jul 2024 10:34:48 GMT, Gilles Duboscq <gdub at openjdk.org> wrote:
>> I don't know how much sense it makes to expose a flag that is only relevant for an optimization in HotSpot (and that exposes the presence of an annotation used only internally by the jdk) to non-hotspot methods
>
> I think JVMCI is already very much JDK-specific so the question is rather whether it's need by any VM that'd try to interact with this JDK implementation. But i don't want to derail this PR, this can be moved up when/if that's needed.
I also agree that this should be moved up to `ResolvedJavaMethod` as the annotation itself is not HotSpot specific and so could easily be relevant for any other VM using the JDK classes (e.g. SVM).
Not that this means you'll need to update `TestResolvedJavaMethod.java` to test the new method but that should be straighforward.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20256#discussion_r1689475237
More information about the hotspot-compiler-dev
mailing list