RFR: 8335257: Refactor code to create Initialized Assertion Predicates into separate class [v4]

Christian Hagedorn chagedorn at openjdk.org
Thu Jul 25 06:33:10 UTC 2024


> This is the next patch for Assertion Predicates. It refactors the code to create an Initialized Assertion Predicate. Changes include:
> 
> - `clone_assertion_predicate_and_initialize()` currently does two things: Cloning a Template Assertion Predicate and creating an Initailized Assertion Predicate. I've split this method into two methods `clone_template_assertion_predicate()` and `create_initialized_assertion_predicate()`:
>   - `clone_template_assertion_predicate()`: Now only clones the template. I have not cleaned the code up further because I will soon replace the `If` node with a dedicated `TemplateAssertionPredicateNode`. 
>   - `create_initialized_assertion_predicate()`: I refactored the code for Initialized Assertion Predicate into a separate class `InitializedAssertionPredicate` which creates the complete Initialized Assertion Predicate `If` with a `HaltNode`. I could get rid of some of the arguments because they can be fetched inside the new class methods.
>   - Moved `assertion_predicate_has_loop_opaque_node()` asserts to both methods.
> - Renamed `AssertionPredicateType::Init_value` -> `AssertionPredicateType::InitValue` (same for last value).
> 
> Thanks,
> Christian

Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Fix product build
 - Merge branch 'refs/heads/master' into JDK-8335257
 - update transformation sketch and rename "Template Assertion Predicate Expression" to "Template Assertion Expression"
 - review Emanuel
 - Merge branch 'refs/heads/master' into JDK-8335257
 - 8335257: Refactor code to create Initialized Assertion Predicates into separate class

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19940/files
  - new: https://git.openjdk.org/jdk/pull/19940/files/6f660554..f393edf7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19940&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19940&range=02-03

  Stats: 20817 lines in 814 files changed: 13012 ins; 4493 del; 3312 mod
  Patch: https://git.openjdk.org/jdk/pull/19940.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19940/head:pull/19940

PR: https://git.openjdk.org/jdk/pull/19940


More information about the hotspot-compiler-dev mailing list