Integrated: 8334647: C2: CastII added by PhaseIdealLoop::add_template_assertion_predicate() should have control

[Roland Westrelin]

On Thu, 20 Jun 2024 14:51:08 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> `PhaseIdealLoop::add_template_assertion_predicate()` creates a new
> `CastII` but doesn't set its control. I think it's good practice to
> always set the control of a `CastII` when it narrows the type of its
> input (it has to be control dependent on some condition that makes the
> narrowing possible). This is also motivated by
> https://bugs.openjdk.org/browse/JDK-8275202 where a node that becomes
> top is used as an indication that control flow where the node changes
> type can constant fold. This only works if control is set correctly.

This pull request has now been integrated.

Changeset: f61a5059
Author:    Roland Westrelin <roland at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f61a50598958e928e9a4d81130b077cd6eaf876a
Stats:     20 lines in 5 files changed: 9 ins; 6 del; 5 mod

8334647: C2: CastII added by PhaseIdealLoop::add_template_assertion_predicate() should have control

Reviewed-by: chagedorn, kvn

-------------

PR: https://git.openjdk.org/jdk/pull/19808