RFR: 8333276: RISC-V: client VM build failure after JDK-8241503

Abdelhak Zaaim duke at openjdk.org
Sat Jun 1 19:41:00 UTC 2024


On Thu, 30 May 2024 14:05:42 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi, please review this patch that fix the client VM build failed for riscv.
> 
> Error log for client VM build to see: [JDK-8333276](https://bugs.openjdk.org/browse/JDK-8333276)
> 
> The root cause is that `src/hotspot/share/code/compiledIC.hpp` include `"opto/c2_MacroAssembler.hpp"`, after that `opto/c2_MacroAssembler.hpp` include `c2_MacroAssembler_riscv.hpp`.
> 
> The fix is that we extracted the `spill_vmask, unspill_vmask` function definitions into `c2_MacroAssembler_riscv.cpp`. `c2_MacroAssembler_riscv.cpp` will only compile if the `COMPILER2` macro is present.
> ### Testing
> - [x] linux-riscv client VM fastdebug native build

Marked as reviewed by abdelhak-zaaim at github.com (no known OpenJDK username).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19481#pullrequestreview-2092165282


More information about the hotspot-compiler-dev mailing list