RFR: 8333394: C2: assert(bol->is_Opaque4() || bol->is_OpaqueInitializedAssertionPredicate()) failed: Opaque node of non-null-check or of Initialized Assertion Predicate [v2]

[Christian Hagedorn]

On Mon, 3 Jun 2024 12:57:57 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/hotspot/jtreg/compiler/predicates/assertion/TestIfWithPhiInput.java
>>   
>>   Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> Looks good to me.

Thanks @TobiHartmann and @rwestrel for your reviews!

> test/hotspot/jtreg/compiler/predicates/assertion/TestIfWithPhiInput.java line 29:
> 
>> 27:  * @bug 8333394
>> 28:  * @summary Test bailout of range check policy with an If with a Phi as condition.
>> 29:  * @run main/othervm -XX:CompileCommand=compileonly,*TestIfWithPhiInput*::* -Xcomp
> 
> Suggestion:
> 
>  * @run main/othervm -XX:CompileCommand=compileonly,*TestIfWithPhiInput*::* -Xcomp -XX:-TieredCompilation
> 
> 
> Just to make sure C2 compilation is triggered.

Good point, added.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19517#issuecomment-2145163713
PR Review Comment: https://git.openjdk.org/jdk/pull/19517#discussion_r1624432570