RFR: 8317720: RISC-V: Implement Adler32 intrinsic [v8]

ArsenyBochkarev duke at openjdk.org
Mon Jun 3 19:38:44 UTC 2024


On Mon, 27 May 2024 14:20:39 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> ArsenyBochkarev has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Partially unroll L_by16_loop
>>  - Fix by64 function for vlen > 128
>>  - Fix by16 function for vlen > 128
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 5303:
> 
>> 5301:     const int remainder = 3;
>> 5302:     adler32_process_bytes_by16(buff, s1, s2, right_16_bits, vtable_16, vzero,
>> 5303:       vbytes, vs1acc, vs2acc, temp0, temp1, temp2, vtemp1, vtemp2, remainder);
> 
> Maybe deserves another `adler32_process_bytes_by32` here? Then you do one `adler32_process_bytes_by32` and one `adler32_process_bytes_by16` for the rest 3 iterations.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18382#discussion_r1624951017


More information about the hotspot-compiler-dev mailing list