RFR: 8333252: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: must find OpaqueLoop* nodes [v2]

[Christian Hagedorn]

On Tue, 4 Jun 2024 15:34:46 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Add braces
>>  - Merge branch 'refs/heads/master' into JDK-8333252
>>  - 8333252: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: must find OpaqueLoop* nodes
>
> src/hotspot/share/opto/loopPredicate.cpp line 1373:
> 
>> 1371:     // Avoid RCE if Counted loop's test is '!='.
>> 1372:     BoolTest::mask bt = cl->loopexit()->test_trip();
>> 1373:     if (bt != BoolTest::lt && bt != BoolTest::gt)
> 
> Since you touching this code can you add `{}` for this condition?

Thanks Vladimir for your review! Yes, absolutely, I've pushed an update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19500#discussion_r1626259620