RFR: 8332119: Incorrect IllegalArgumentException for C2 compiled permute kernel [v3]
Jatin Bhateja
jbhateja at openjdk.org
Wed Jun 5 02:34:26 UTC 2024
> Currently inline expansion of vector to shuffle conversion simply type casts the vector holding indexes to byte vector[1] where as fallback implementation[2] also wraps the indexes to a valid index range [0, VEC_LEN-1) or generates a -ve index for exceptional / OOB indices.
>
> This patch extends the conversion inline expander to match the fall back implementation. This imposes around 20% performance tax on Vector.toShuffle() intrinsic but fixes this functional bug.
>
> Kindly review and share your feedback.
>
> Best Regards,
> Jatin
>
> PS: Patch also fixes an incorrectness issue reported with [JDK-8332118](https://bugs.openjdk.org/browse/JDK-8332118)
>
> [1] https://github.com/openjdk/jdk/blob/master/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatVector.java#L2352
> [2] https://github.com/openjdk/jdk/blob/master/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractShuffle.java#L58
Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
Review comments resolutions.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19442/files
- new: https://git.openjdk.org/jdk/pull/19442/files/102b78ae..16996e57
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19442&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19442&range=01-02
Stats: 16 lines in 1 file changed: 12 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/19442.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19442/head:pull/19442
PR: https://git.openjdk.org/jdk/pull/19442
More information about the hotspot-compiler-dev
mailing list