Integrated: 8332499: Gtest codestrings.validate_vm fail on linux x64 when hsdis is present

SendaoYan syan at openjdk.org
Wed Jun 5 05:13:01 UTC 2024


On Mon, 20 May 2024 12:24:09 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   There's some arch-specific code to trim trailing entries as descripted in [JDK-8332499](https://bugs.openjdk.org/browse/JDK-8332499). Only change the gtest testcase, the risk is low.
> 
> On linux x86_64, before this PR, after deal with `std::regex_replace(tmp4, std::regex("\\s+<addr>:\\s+hlt[ \\t]+(?!\\n\\s+;;)"), "")`, the output differents because the first output has trailing empty spaces, show as below:
> 
> -  <addr>:   nop    
> +  <addr>:   nop
> 
> So we need to delete the empty spaces after `<addr>:   nop` use `std::regex_replace(tmp5, std::regex("(\\s+<addr>:\\s+nop)[ \\t]*"), "$1")`
> 
> 
> Additional test:
> - [x] codestrings.validate_vm on linux x64
> - [x] codestrings.validate_vm on linux aarch64
> - [x] codestrings.validate_vm on linux riscv64

This pull request has now been integrated.

Changeset: 7dbd0338
Author:    SendaoYan <syan at openjdk.org>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7dbd03388eef9cddbab6a622338b00ce250be3dc
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

8332499: Gtest codestrings.validate_vm fail on linux x64 when hsdis is present

Reviewed-by: thartmann, chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/19309


More information about the hotspot-compiler-dev mailing list