RFR: 8331311: C2: Big Endian Port of 8318446: optimize stores into primitive arrays by combining values into larger store [v4]

Richard Reingruber rrich at openjdk.org
Wed Jun 5 06:56:57 UTC 2024


On Fri, 24 May 2024 08:18:41 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Eliminate IS_BIG_ENDIAN and always execute both variants
>
> src/hotspot/share/opto/memnode.cpp line 3310:
> 
>> 3308:     Node* hi = first->in(MemNode::ValueIn);
>> 3309:     Node* lo = _store->in(MemNode::ValueIn);
>> 3310: #endif // VM_LITTLE_ENDIAN
> 
> A `swap` could be more concise. But I leave that up to you ;)

You're right. It's better to just swap `hi` with `lo` and it matches the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19218#discussion_r1627088951


More information about the hotspot-compiler-dev mailing list