RFR: 8333252: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: must find OpaqueLoop* nodes [v2]

[Christian Hagedorn]

On Wed, 5 Jun 2024 06:52:17 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Add braces
>>  - Merge branch 'refs/heads/master' into JDK-8333252
>>  - 8333252: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: must find OpaqueLoop* nodes
>
> test/hotspot/jtreg/compiler/predicates/assertion/TestTemplateWithoutOpaqueLoopNodes.java line 29:
> 
>> 27:  * @summary Test that no Template Assertion Predicate is created in Loop Prediction for one iteration loop.
>> 28:  * @run main/othervm -Xcomp -XX:CompileCommand=compileonly,*TestTemplateWithoutOpaqueLoopNodes::test
>> 29:  *                   compiler.predicates.assertion.TestTemplateWithoutOpaqueLoopNodes
> 
> Could it make sense to repeat calling `test` a few times more, and also add a run without Xcomp? I leave that to you, I guess the fuzzer generates these patterns so if there was a bug it would find it.

I guess it does not hurt to add such a run. I've pushed an update

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19500#discussion_r1627203523