RFR: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64 [v2]
Gui Cao
gcao at openjdk.org
Thu Jun 6 05:31:43 UTC 2024
On Wed, 5 Jun 2024 14:49:30 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
> On the other hand you might need to add the check here:
>
> https://github.com/openjdk/jdk/blob/1235a453eef4a838fe07009b0c5e8a962b527bb4/test/hotspot/jtreg/compiler/vectorapi/VectorGatherMaskFoldingTest.java#L966
>
>
> and here:
> https://github.com/openjdk/jdk/blob/1235a453eef4a838fe07009b0c5e8a962b527bb4/test/hotspot/jtreg/compiler/vectorapi/VectorGatherMaskFoldingTest.java#L1098
fixed.
> test/hotspot/jtreg/compiler/vectorapi/VectorGatherMaskFoldingTest.java line 785:
>
>> 783: doubleVector.intoArray(res, 0, doubleIndices, 0, doubleVectorMask);
>> 784: doubleVector.intoArray(res2, 0, doubleIndices, 0, doubleVectorMask2);
>> 785: Asserts.assertFalse(D_SPECIES.length() != 1 && Arrays.equals(res, res2));
>
> Same here.
I've fixed all of the above comments.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19473#issuecomment-2151439427
PR Review Comment: https://git.openjdk.org/jdk/pull/19473#discussion_r1628794733
More information about the hotspot-compiler-dev
mailing list